Skip to content

Config entry options#18929

Merged
Kane610 merged 48 commits into
home-assistant:devfrom
Kane610:config-entry-options
Feb 22, 2019
Merged

Config entry options#18929
Kane610 merged 48 commits into
home-assistant:devfrom
Kane610:config-entry-options

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Dec 2, 2018 •
edited by emontnemery
Loading

Description:

Options support for configuration entries.

Uses same data entry flow as config entries.

How to identify if a configuration entry supports options flow:
A static method in config flow class called "async_get_options_flow" returns options flow handler.

Finalizing options flow triggers an update to configuration entry that will also trigger update listeners.

Pull request in developers.home-assistant.io with documentation: home-assistant/developers.home-assistant#185

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 requested a review from a team as a code owner December 2, 2018 17:11
@ghost ghost assigned Kane610 Dec 2, 2018
@ghost ghost added the in progress label Dec 2, 2018
houndci-bot
houndci-bot reviewed Dec 2, 2018
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
Comment thread homeassistant/components/deconz/config_flow.py Outdated
balloob
balloob reviewed Dec 3, 2018
View reviewed changes
Comment thread homeassistant/components/deconz/config_flow.py Outdated
balloob
balloob reviewed Dec 3, 2018
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
MartinHjelmare
MartinHjelmare reviewed Dec 3, 2018
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
@Kane610 Kane610 force-pushed the config-entry-options branch from 02553f6 to 05ce9ee Compare January 16, 2019 18:14
@Kane610 Kane610 force-pushed the config-entry-options branch from 3394cf5 to 32dade2 Compare February 1, 2019 17:30
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/components/config/config_entries.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/components/config/config_entries.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/components/config/config_entries.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/components/deconz/__init__.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/components/deconz/config_flow.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/components/deconz/config_flow.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
balloob
balloob reviewed Feb 7, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
houndci-bot
houndci-bot reviewed Feb 12, 2019
View reviewed changes
Comment thread tests/test_config_entries.py Outdated
Comment thread tests/test_config_entries.py Outdated
balloob
balloob reviewed Feb 12, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
@balloob balloob mentioned this pull request Feb 12, 2019
Merged
houndci-bot
houndci-bot reviewed Feb 13, 2019
View reviewed changes
Comment thread tests/components/config/test_config_entries.py Outdated
Comment thread tests/components/config/test_config_entries.py Outdated
Comment thread tests/components/config/test_config_entries.py Outdated
Comment thread homeassistant/components/config/config_entries.py Outdated
houndci-bot
houndci-bot reviewed Feb 13, 2019
View reviewed changes
Comment thread tests/components/config/test_config_entries.py Outdated
Comment thread homeassistant/components/deconz/__init__.py Outdated
@Kane610 Kane610 changed the title WIP - Config entry options Config entry options Feb 13, 2019
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Feb 13, 2019

@balloob @MartinHjelmare I'd say this is ready for a proper bashing 👍

houndci-bot
houndci-bot reviewed Feb 15, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
MartinHjelmare
MartinHjelmare reviewed Feb 15, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
Comment thread homeassistant/config_entries.py
balloob
balloob reviewed Feb 15, 2019
View reviewed changes
Comment thread homeassistant/components/config/config_entries.py Outdated
balloob
balloob reviewed Feb 19, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
balloob
balloob reviewed Feb 19, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
balloob
balloob reviewed Feb 19, 2019
View reviewed changes
Comment thread homeassistant/config_entries.py Outdated
balloob
balloob reviewed Feb 19, 2019
View reviewed changes
Comment thread tests/components/config/test_config_entries.py Outdated
balloob
balloob approved these changes Feb 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it looks great ! 🎉 Few tiny comments left.

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Feb 20, 2019

See #18929 (comment).

@Kane610 Kane610 mentioned this pull request Feb 22, 2019
Merged
@Kane610 Kane610 merged commit d971202 into home-assistant:dev Feb 22, 2019
@ghost ghost removed the in progress label Feb 22, 2019
@Kane610 Kane610 deleted the config-entry-options branch February 22, 2019 17:01
@balloob balloob mentioned this pull request Mar 6, 2019
Merged
@Kane610 Kane610 mentioned this pull request Mar 11, 2019
Closed
@ghost ghost mentioned this pull request Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balloob balloob balloob approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Kane610 Kane610

Labels

cla-signed core integration: deconz

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kane610 @MartinHjelmare @balloob @houndci-bot @homeassistant